Description:
It looks like some extensions, like the Ultimate SD Upscale, have submodules, but these submodules aren’t being correctly checked out by the ComfyUI Manager in the desktop version. This results in broken nodes.
After encountering this issue, the ComfyUI Manager also fails to start
The extensions now seem to be versioned from a third-party package hub and are no longer functioning as git repositories. The only exceptions are those with “unknown” versions, which still fetch correctly from git and are proper git repositories.
Since they’re not git repos anymore, I can’t even initialize the submodules myself as a quick fix.
Workaround:
A workaround I found is to clone the extension manually (from git) with submodules using:
git clone --recurse-submodules https://github.com/ssitu/ComfyUI_UltimateSDUpscale.git
After doing this, the manager doesn’t crash, and the node works as expected.
trace
2024-11-15 23:06:39,576 - root - WARNING - Traceback (most recent call last):
File "C:\Users\user\AppData\Local\Programs\@comfyorgcomfyui-electron\resources\ComfyUI\nodes.py", line 2012, in load_custom_node
module_spec.loader.exec_module(module)
File "<frozen importlib._bootstrap_external>", line 995, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "D:/AI/ComfyUI\custom_nodes/ComfyUI_UltimateSDUpscale\__init__.py", line 32, in <module>
from .nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "D:\AI/ComfyUI\custom_nodes/ComfyUI_UltimateSDUpscale\nodes.py", line 6, in <module>
from usdu_patch import usdu
File "D:\AI\ComfyUI\custom_nodes\ComfyUI_UltimateSDUpscale\usdu_patch.py", line 2, in <module>
from repositories import ultimate_upscale as usdu
File "D:\AI\ComfyUI\custom_nodes\ComfyUI_UltimateSDUpscale\repositories\__init__.py", line 14, in <module>
spec.loader.exec_module(ultimate_upscale)
File "<frozen importlib._bootstrap_external>", line 991, in exec_module
File "<frozen importlib._bootstrap_external>", line 1128, in get_code
File "<frozen importlib._bootstrap_external>", line 1186, in get_data
FileNotFoundError: [Errno 2] No such file or directory: 'D:\\AI\\ComfyUI\\custom_nodes\\ComfyUI_UltimateSDUpscale\\repositories\\ultimate_sd_upscale\\scripts\\ultimate-upscale.py'
2024-11-15 23:06:39,576 - root - WARNING - Cannot import D:/AI/ComfyUI\custom_nodes/ComfyUI_UltimateSDUpscale module for custom nodes: [Errno 2] No such file or directory: 'D:\\AI\\ComfyUI\\custom_nodes\\ComfyUI_UltimateSDUpscale\\repositories\\ultimate_sd_upscale\\scripts\\ultimate-upscale.py'
2024-11-15 23:06:39,582 - root - WARNING - Traceback (most recent call last):
File "C:\Users\user\AppData\Local\Programs\@comfyorgcomfyui-electron\resources\ComfyUI\nodes.py", line 2012, in load_custom_node
module_spec.loader.exec_module(module)
File "<frozen importlib._bootstrap_external>", line 995, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "C:\Users\user\AppData\Local\Programs\@comfyorgcomfyui-electron\resources\ComfyUI\custom_nodes\ComfyUI-Manager\__init__.py", line 6, in <module>
from .glob import manager_server
File "C:\Users\user\AppData\Local\Programs\@comfyorgcomfyui-electron\resources\ComfyUI\custom_nodes\ComfyUI-Manager\glob\manager_server.py", line 16, in <module>
import manager_core as core
ModuleNotFoundError: No module named 'manager_core'
2024-11-15 23:06:39,582 - root - WARNING - Cannot import C:\Users\user\AppData\Local\Programs\@comfyorgcomfyui-electron\resources\ComfyUI\custom_nodes\ComfyUI-Manager module for custom nodes: No module named 'manager_core'
2024-11-15 23:06:39,583 - root - WARNING - Skip C:\Users\user\AppData\Local\Programs\@comfyorgcomfyui-electron\resources\ComfyUI\custom_nodes\DesktopSettingsExtension module for custom nodes due to the lack of NODE_CLASS_MAPPINGS.
2024-11-15 23:06:39,584 - root - INFO -
Import times for custom nodes:
2024-11-15 23:06:39,584 - root - INFO - 0.0 seconds: C:\Users\user\AppData\Local\Programs\@comfyorgcomfyui-electron\resources\ComfyUI\custom_nodes\websocket_image_save.py
2024-11-15 23:06:39,584 - root - INFO - 0.0 seconds (IMPORT FAILED): C:\Users\user\AppData\Local\Programs\@comfyorgcomfyui-electron\resources\ComfyUI\custom_nodes\DesktopSettingsExtension
2024-11-15 23:06:39,584 - root - INFO - 0.0 seconds: D:/AI/ComfyUI\custom_nodes/cg-image-picker@2_13_1
2024-11-15 23:06:39,585 - root - INFO - 0.0 seconds: D:/AI/ComfyUI\custom_nodes/ComfyUI-Jjk-Nodes
2024-11-15 23:06:39,585 - root - INFO - 0.0 seconds (IMPORT FAILED): C:\Users\user\AppData\Local\Programs\@comfyorgcomfyui-electron\resources\ComfyUI\custom_nodes\ComfyUI-Manager
2024-11-15 23:06:39,585 - root - INFO - 0.0 seconds (IMPORT FAILED): D:/AI/ComfyUI\custom_nodes/ComfyUI_UltimateSDUpscale
2024-11-15 23:06:39,585 - root - INFO - 0.0 seconds: D:/AI/ComfyUI\custom_nodes/ComfyUI-GGUF